Skip to content

feat: Expose pub get's --offline flag on the bootstrap command#756

Merged
spydon merged 5 commits intomainfrom
feat/pub-get-offline
Oct 7, 2024
Merged

feat: Expose pub get's --offline flag on the bootstrap command#756
spydon merged 5 commits intomainfrom
feat/pub-get-offline

Conversation

@spydon
Copy link
Collaborator

@spydon spydon commented Sep 13, 2024

Description

Adds the --offline flag to the bootstrap command.

Fixes: #714

Type of Change

  • feat -- New feature (non-breaking change which adds functionality)
  • 🛠️ fix -- Bug fix (non-breaking change which fixes an issue)
  • ! -- Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 refactor -- Code refactor
  • ci -- Build configuration change
  • 📝 docs -- Documentation
  • 🗑️ chore -- Chore

@docs-page
Copy link

docs-page bot commented Sep 13, 2024

To view this pull requests documentation preview, visit the following URL:

melos.invertase.dev/~756

Documentation is deployed and generated using docs.page.

@spydon spydon changed the title feat: Expose 'pub get --offline' flag on bootstrap command feat: Expose pub get's --offline flag on the bootstrap command Sep 13, 2024
@spydon
Copy link
Collaborator Author

spydon commented Sep 13, 2024

@jessicatarra could you review this small one? :)

@jessicatarra
Copy link
Contributor

Looks good to me! Great work :) There are some tests that are failing, but they are also failing in the main branch and it's not due to this work. Let's open a new issue for this and maybe address it in this PR as well.

@spydon
Copy link
Collaborator Author

spydon commented Sep 16, 2024

Looks good to me! Great work :) There are some tests that are failing, but they are also failing in the main branch and it's not due to this work. Let's open a new issue for this and maybe address it in this PR as well.

Thanks, a very small one. 😅
We have an issue open for the tests here:
#724

@spydon spydon merged commit b432749 into main Oct 7, 2024
@spydon spydon deleted the feat/pub-get-offline branch October 7, 2024 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

request: Add --offline flag to melos bootstrap.

2 participants